-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #783
base: master
Are you sure you want to change the base?
add task solution #783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, keep going. Can't find issue with background
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replied about header in chat. Waiting other sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done.
Needs some improvements.
- hover effects for these cards looks unexpected. is it should have such behavior?
- add transition for hover on social icon and add hover (change color) for email, address, phone links
- center apply button. why do you need to make it with position absolut on some widht and hardcode margins? it can be with normal document flow (one element below other).
margin: 0 auto can center button horizontally.
- check and comare carefully design with your implementation. For example spaces between cards, centering horizontally for tablet and mobild and so on.
actual:
- after click on burger icon nothing happens. menu is not open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Keep doing:
Consider fixing validation errors
Consider disabling scroll under the menu and enabling the menu scroll
Add a proper href attribute here
The button should be of type submit and should be inside the form
Some sections on mobiles are shifted
This link leads to 404 page, consider fixing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Need to make all these fields are required before sending and need to check width for the inputs
- These elements should be on the center horizontally
-
Also, all content on the page must have a maximum width and must be centered on the page horizontally, and now it stretches to the full width of the browser window
-
You need to hide the text below the menu
- Need to fix on the large screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done
DEMO LINK